-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Campaign #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Campaign #2143
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Parvinmh is attempting to deploy a commit to the Pean Team on Vercel. A member of the Team first needs to authorize it. |
| * Resume idle timers when page becomes visible | ||
| */ | ||
| private resumeIdleTimers(): void { | ||
| // Implementation for resuming idle timers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be implemented I assume?
| updatedAt?: string; | ||
| author?: string; | ||
| tags?: string[]; | ||
| priority?: number; // Priority for when multiple campaigns match (higher = higher priority) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this currently implemented?
| if (this.isInitialized) return; | ||
|
|
||
| // Track session count | ||
| const sessionCountKey = "introjs-campaign-session-count"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be in configs.
| updateStatus('Initializing campaigns from JSON file...'); | ||
|
|
||
| // Initialize campaigns from JSON file (correct path for this directory) | ||
| await introJs.initializeCampaigns("./campaigns/first-visit-tour.json"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How this would work in a browser environment? How do we do file I/O when running in browser context?
No description provided.